Skip to content

Typescript improvements #316

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
May 21, 2018
Merged

Typescript improvements #316

merged 3 commits into from
May 21, 2018

Conversation

zenspider
Copy link
Contributor

This fixes the same problems we were having in JS for TS.

zenspider added 3 commits May 17, 2018 13:43
@zenspider
Consistency fixes for javascript/main.rb.
90bc786
@zenspider
Consistency fixes for typescript/main.rb
046c549
@zenspider
Brought over 99% of the filter improvements from javascript to typesc…
fb15606 
…ript.

I didn't bring over the directives filter as I don't see that in
typescript (yet).

Otherwise, the files are now nearly identical. This is begging for one
to be a subclass of the other w/ just the name/extension differences.
ale7714
ale7714 approved these changes May 21, 2018
View reviewed changes
Copy link

@ale7714 ale7714 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! I think extracting some of the common logic would be nice but shouldn't block merging this changes.

@ale7714 ale7714 merged commit 7423ae7 into master May 21, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ale7714 ale7714 ale7714 approved these changes

Assignees

@ABaldwinHunter ABaldwinHunter

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@zenspider @ale7714 @ABaldwinHunter